Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DowngradePhp73] Skip inside define check on DowngradePhp73JsonConstRector #1787

Merged
merged 2 commits into from
Feb 8, 2022
Merged

[DowngradePhp73] Skip inside define check on DowngradePhp73JsonConstRector #1787

merged 2 commits into from
Feb 8, 2022

Conversation

samsonasik
Copy link
Member

ref #1782 (comment)

The existing functionaly is:

         if (\defined('JSON_THROW_ON_ERROR')) {
-            $options = $options & ~\JSON_THROW_ON_ERROR;
+            $options = $options & ~0;

which invalid and should be skipped.

@samsonasik samsonasik force-pushed the skip-inside-define-check branch from d17cb97 to 858c271 Compare February 8, 2022 23:20
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik samsonasik enabled auto-merge (squash) February 8, 2022 23:32
@samsonasik samsonasik merged commit cd7140a into main Feb 8, 2022
@samsonasik samsonasik deleted the skip-inside-define-check branch February 8, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik